Skip to content

2287 Enhance decollate to support list and Tensor#2288

Merged
Nic-Ma merged 11 commits intoProject-MONAI:devfrom
Nic-Ma:2287-enhance-decollate
Jun 1, 2021
Merged

2287 Enhance decollate to support list and Tensor#2288
Nic-Ma merged 11 commits intoProject-MONAI:devfrom
Nic-Ma:2287-enhance-decollate

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented May 31, 2021

Fixes #2287 .

Description

This PR added list and Tensor support to the decollate_batch API, it can be useful to decollate the model output for post transforms and metrics.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 31, 2021

/black

@Nic-Ma Nic-Ma force-pushed the 2287-enhance-decollate branch from 51fa488 to 40f243a Compare May 31, 2021 06:13
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli May 31, 2021 06:13
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 31, 2021

/black

monai-bot and others added 2 commits May 31, 2021 06:21
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 31, 2021

/black

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I put comments inline

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 1, 2021

Hi @wyli ,

Thanks for your review!
I updated the PR according to your comments.
Could you please help review it again?

Thanks in advance.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 1, 2021

/black

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Nic-Ma Nic-Ma enabled auto-merge (squash) June 1, 2021 22:26
@Nic-Ma Nic-Ma merged commit 168506f into Project-MONAI:dev Jun 1, 2021
@Nic-Ma Nic-Ma deleted the 2287-enhance-decollate branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

decollate needs to support more types

3 participants