Skip to content

Bringing CRF implementation inline with literature#2261

Merged
charliebudd merged 7 commits intoProject-MONAI:devfrom
charliebudd:crf-compatability-change
May 27, 2021
Merged

Bringing CRF implementation inline with literature#2261
charliebudd merged 7 commits intoProject-MONAI:devfrom
charliebudd:crf-compatability-change

Conversation

@charliebudd
Copy link
Copy Markdown
Collaborator

@charliebudd charliebudd commented May 26, 2021

In the current version the compatability transform is extended to take into account neighbouring voxels. While this produces smoother results, it may well over smooth. While possibly worth some investigation it should be implemented as in the paper for now. This PR brings it inline with the literature.

Signed-off-by: chaliebudd [email protected]

Status

Ready

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Co-authored-by: Richard Brown <[email protected]>
Signed-off-by: chaliebudd <[email protected]>
@charliebudd charliebudd force-pushed the crf-compatability-change branch from 7df2acc to 5c2a4d7 Compare May 27, 2021 09:39
@charliebudd charliebudd force-pushed the crf-compatability-change branch from 25c52f2 to 52270d8 Compare May 27, 2021 12:20
@charliebudd charliebudd changed the title [WIP]Bringing CRF implementation inline with literature Bringing CRF implementation inline with literature May 27, 2021
@charliebudd charliebudd merged commit 12bbe77 into Project-MONAI:dev May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants