2251 Update type hints for act and norm#2254
Merged
wyli merged 1 commit intoProject-MONAI:devfrom May 26, 2021
Merged
Conversation
Signed-off-by: Yiheng Wang <[email protected]>
rijobro
reviewed
May 26, 2021
Comment on lines
+40
to
+41
| norm_type: Optional[Union[Tuple, str]] = "BATCH", | ||
| acti_type: Optional[Union[Tuple, str]] = "LEAKYRELU", |
Contributor
There was a problem hiding this comment.
What's wrong with leaving the right sight of the equals as they were? E.g., Norm.BATCH and Act.LEAKYRELU?
Contributor
Author
There was a problem hiding this comment.
Nothing wrong, I just try to use the same format as in https://github.com/Project-MONAI/MONAI/blob/dev/monai/networks/blocks/convolutions.py#L104
rijobro
approved these changes
May 26, 2021
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
Signed-off-by: Yiheng Wang <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
Signed-off-by: Yiheng Wang <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
Signed-off-by: Yiheng Wang <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
Signed-off-by: Yiheng Wang <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
Signed-off-by: Yiheng Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang [email protected]
Fixes #2251 .
Description
A few sentences describing the changes proposed in this pull request.
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.