Skip to content

2221 Change InvertD and TransformInverter to in-place operation#2235

Merged
wyli merged 12 commits intoProject-MONAI:devfrom
Nic-Ma:2221-inplace-invert
May 25, 2021
Merged

2221 Change InvertD and TransformInverter to in-place operation#2235
wyli merged 12 commits intoProject-MONAI:devfrom
Nic-Ma:2221-inplace-invert

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented May 24, 2021

Fixes #2221 .

Description

This PR changed the invert operation of InvertD transform and TransformInverter to be in-place operation.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 24, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli May 24, 2021 06:15
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 25, 2021

thanks, Invertd is a complex one, is it possible to explain keys orig_keys meta_keys orig_meta_keys meta_key_postfix? shall we create a simple tutorial and put a tutorial link here? otherwise this one is not easy to use...

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 25, 2021 •
edited
Loading

Hi @wyli ,

Make sense, let me try to add some examples in the doc-string first.

Thanks.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 25, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 25, 2021

Hi @wyli ,

I added detailed example in the doc-string of Invertd transform, paste the screenshot of the web page:
image

Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 25, 2021

thanks, could you please move it into tutorials as a notebook? then it'll be very helpful when explaining this transform.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 25, 2021 •
edited
Loading

Hi @wyli ,

Sure, I will update this tutorial example to use the latest API when this PR merged:
https://github.com/Project-MONAI/tutorials/blob/master/3d_segmentation/torch/unet_inference_dict.py

Thanks.

wyli
wyli approved these changes May 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli enabled auto-merge (squash) May 25, 2021 17:03
@wyli wyli merged commit 013186d into Project-MONAI:dev May 25, 2021
@Nic-Ma Nic-Ma deleted the 2221-inplace-invert branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change Invertd transform to be in-place operation

3 participants

@Nic-Ma @wyli @monai-bot