Skip to content

fix type for margin argument in CropForegroundd#2234

Merged
rijobro merged 1 commit intoProject-MONAI:devfrom
ambroslins:fix-cropforegroundd-margin-type
May 24, 2021
Merged

fix type for margin argument in CropForegroundd#2234
rijobro merged 1 commit intoProject-MONAI:devfrom
ambroslins:fix-cropforegroundd-margin-type

Conversation

@ambroslins
Copy link
Copy Markdown
Contributor

Description

This PR changes the type of the margin argument of the CropForegroundd transformation from int to Union[Sequence[int], int] to match the array based version and correspond with the docs.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Copy link
Copy Markdown
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rijobro rijobro merged commit 33539db into Project-MONAI:dev May 24, 2021
wyli pushed a commit that referenced this pull request May 26, 2021
wyli pushed a commit that referenced this pull request May 26, 2021
wyli pushed a commit that referenced this pull request May 26, 2021
wyli pushed a commit that referenced this pull request May 26, 2021
wyli pushed a commit that referenced this pull request May 26, 2021
wyli pushed a commit that referenced this pull request May 27, 2021
wyli pushed a commit that referenced this pull request May 27, 2021
wyli pushed a commit that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants