1994 - adds pip install tests by wyli · Pull Request #2233 · Project-MONAI/MONAI

wyli · 2021-05-22T22:51:04Z

Fixes #1994

adds package min_tests for pre-merge ci/cd
adds package full unit tests for nightly ci/cd

Status

Ready

tested:

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).
New tests added to cover the changes.
Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
Quick tests passed locally by running ./runtests.sh --quick --unittests.
In-line docstrings updated.

Signed-off-by: Wenqi Li <[email protected]>

This reverts commit b6d86d6. Signed-off-by: Wenqi Li <[email protected]>

Signed-off-by: Wenqi Li <[email protected]>

This reverts commit 44cddc0. Signed-off-by: Wenqi Li <[email protected]>

Signed-off-by: Wenqi Li <[email protected]>

.github/workflows/cron.yml

rijobro · 2021-05-24T09:25:18Z

Am I correct in understanding that this PR doesn't install from pypi, but from tar.gz? Do you think this changes the "realness" of the test at all?

wyli · 2021-05-24T11:41:55Z

Am I correct in understanding that this PR doesn't install from pypi, but from tar.gz? Do you think this changes the "realness" of the test at all?

yes this is quite realistic, except that "pip install requirements-dev.txt" might hide some dependency errors. but we need it to construct a testing environment. we should consider refactoring requirements*.txt.

for the tar.gz, another approach is to upload the tar.gz to testPyPI server and pip install from there. this pipeline will then depend on the availability of the test PyPI server, and for now I don't think it's really needed.

rijobro · 2021-05-24T11:49:30Z

Ok, it sounds good to me. I can't really offer an opinion as to best practice, but happy to approve.

Has the workflow been run? Looking at the cron jobs and can't see cron-pip anywhere.

wyli · 2021-05-24T11:54:43Z

thanks, the cron will be available after merging the config. I had a test separately here: https://github.com/Project-MONAI/MONAI/actions/runs/867438967

rijobro

Great, thanks!

* add pypi quick tests Signed-off-by: Wenqi Li <[email protected]> * temp tests Signed-off-by: Wenqi Li <[email protected]> * update Signed-off-by: Wenqi Li <[email protected]> * cron pypi tests Signed-off-by: Wenqi Li <[email protected]> * temp tests Signed-off-by: Wenqi Li <[email protected]> * Revert "temp tests" This reverts commit b6d86d6. Signed-off-by: Wenqi Li <[email protected]> * update Signed-off-by: Wenqi Li <[email protected]> * revise cron Signed-off-by: Wenqi Li <[email protected]> * Revert "temp tests" This reverts commit 44cddc0. Signed-off-by: Wenqi Li <[email protected]> * docstring Signed-off-by: Wenqi Li <[email protected]> * update setup.cfg Signed-off-by: Wenqi Li <[email protected]>

wyli added 11 commits May 22, 2021 21:12

add pypi quick tests

8ea3c73

Signed-off-by: Wenqi Li <[email protected]>

temp tests

b6d86d6

Signed-off-by: Wenqi Li <[email protected]>

update

111e810

Signed-off-by: Wenqi Li <[email protected]>

cron pypi tests

d60ae0c

Signed-off-by: Wenqi Li <[email protected]>

temp tests

44cddc0

Signed-off-by: Wenqi Li <[email protected]>

Revert "temp tests"

968077b

This reverts commit b6d86d6. Signed-off-by: Wenqi Li <[email protected]>

update

668bca8

Signed-off-by: Wenqi Li <[email protected]>

revise cron

f625bc8

Signed-off-by: Wenqi Li <[email protected]>

Revert "temp tests"

e62749c

This reverts commit 44cddc0. Signed-off-by: Wenqi Li <[email protected]>

docstring

543c44e

Signed-off-by: Wenqi Li <[email protected]>

update setup.cfg

047a0c5

Signed-off-by: Wenqi Li <[email protected]>

wyli requested review from Nic-Ma, charliebudd, ericspod and rijobro May 22, 2021 22:51

rijobro reviewed May 24, 2021

View reviewed changes

.github/workflows/cron.yml Show resolved Hide resolved

Merge branch 'dev' into adds-pypi-tests

ceec8fe

rijobro approved these changes May 24, 2021

View reviewed changes

wyli enabled auto-merge (squash) May 24, 2021 12:03

wyli merged commit 49f8ecd into dev May 24, 2021

wyli deleted the adds-pypi-tests branch May 24, 2021 12:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1994 - adds pip install tests#2233

1994 - adds pip install tests#2233
wyli merged 12 commits intodevfrom
adds-pypi-tests

wyli commented May 22, 2021

Uh oh!

Uh oh!

rijobro commented May 24, 2021

Uh oh!

wyli commented May 24, 2021

Uh oh!

rijobro commented May 24, 2021

Uh oh!

wyli commented May 24, 2021 •

edited

Loading

Uh oh!

rijobro left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

wyli commented May 22, 2021

Status

Types of changes

Uh oh!

Uh oh!

rijobro commented May 24, 2021

Uh oh!

wyli commented May 24, 2021

Uh oh!

rijobro commented May 24, 2021

Uh oh!

wyli commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rijobro left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wyli commented May 24, 2021 •

edited

Loading