Skip to content

2026 Make all the data temporarily available for post transforms#2222

Merged
wyli merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:2026-temp-combine-data
May 21, 2021
Merged

2026 Make all the data temporarily available for post transforms#2222
wyli merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:2026-temp-combine-data

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented May 20, 2021

Fixes #2026 .

Description

This PR tried to temporarily combine batch and output to make all the data available for post transforms.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli May 20, 2021 08:57
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 20, 2021

/black

@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 20, 2021

/integration-test

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 21, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 21, 2021

/integration-test

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 25d4b5a into Project-MONAI:dev May 21, 2021
@Nic-Ma Nic-Ma deleted the 2026-temp-combine-data branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide all available data in engine.state.output of workflows

3 participants