Skip to content

PHL memory leak fix#2216

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
charliebudd:phl-memory-leak
May 19, 2021
Merged

PHL memory leak fix#2216
wyli merged 3 commits intoProject-MONAI:devfrom
charliebudd:phl-memory-leak

Conversation

@charliebudd
Copy link
Copy Markdown
Collaborator

Signed-off-by: chaliebudd [email protected]

Fixes #2098.

Description

Some allocated gpu memory was not being freed.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

Signed-off-by: chaliebudd <[email protected]>
@charliebudd charliebudd requested a review from wyli May 19, 2021 15:10
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@charliebudd
Copy link
Copy Markdown
Collaborator Author

This might be a good time to make a hotfix branch so we can start collecting bugfixes to merge it into master without bringing in the feature changes in dev.

@ericspod

@wyli wyli merged commit 26ee695 into Project-MONAI:dev May 19, 2021
wyli added a commit that referenced this pull request May 26, 2021
Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 27, 2021
Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 27, 2021
Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 27, 2021
Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running CRF layer raises CUDA error: an illegal memory access was encountered

2 participants