Skip to content

2180 Add RandScaleCrop transform#2194

Merged
wyli merged 13 commits intoProject-MONAI:devfrom
Nic-Ma:2180-add-randscalecrop
May 14, 2021
Merged

2180 Add RandScaleCrop transform#2194
wyli merged 13 commits intoProject-MONAI:devfrom
Nic-Ma:2180-add-randscalecrop

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented May 13, 2021

Fixes #2180 .

Description

This PR added the RandScaleCrop transform to crop images with different sizes but same scale ratio.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 13, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli May 13, 2021 10:32
@Nic-Ma Nic-Ma force-pushed the 2180-add-randscalecrop branch from 5574842 to a6674e7 Compare May 13, 2021 10:45
@rijobro
Copy link
Copy Markdown
Contributor

rijobro commented May 14, 2021

Should we have a deterministic version? I know we can have deterministic behaviour by setting the scale, but it won't be cached by CacheDataset for example.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 14, 2021 •
edited
Loading

Should we have a deterministic version? I know we can have deterministic behaviour by setting the scale, but it won't be cached by CacheDataset for example.

Sounds interesting, let me try to implement a ScaleCenterCrop transform in another PR next week.

Thanks.

wyli
wyli reviewed May 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I put minor comments inline

@Nic-Ma Nic-Ma force-pushed the 2180-add-randscalecrop branch from 3d1d2be to a84306b Compare May 14, 2021 16:23
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 14, 2021

/black

wyli
wyli approved these changes May 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli enabled auto-merge (squash) May 14, 2021 17:17
@wyli wyli merged commit 97de238 into Project-MONAI:dev May 14, 2021
@Nic-Ma Nic-Ma deleted the 2180-add-randscalecrop branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add RandScaleCrop transform and inverse operation

4 participants

@Nic-Ma @rijobro @wyli @monai-bot