Merged
Conversation
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Nic-Ma
reviewed
May 11, 2021
Signed-off-by: Richard Brown <[email protected]>
Nic-Ma
approved these changes
May 11, 2021
monai/data/test_time_augmentation.py
Outdated
| num_workers: int, | ||
| inferrer_fn: Callable, | ||
| device: Optional[Union[str, torch.device]] = "cuda" if torch.cuda.is_available() else "cpu", | ||
| device: Union[str, torch.device] = torch.device("cpu"), |
Contributor
There was a problem hiding this comment.
To solve the flake8 issue, maybe you can default to a str "cpu", like what we did for MONAI metrics:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/handlers/iteration_metric.py#L51
Thanks.
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
yanielc
pushed a commit
to yanielc/MONAI
that referenced
this pull request
May 13, 2021
fix set visible devices Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc
pushed a commit
to yanielc/MONAI
that referenced
this pull request
May 13, 2021
fix set visible devices Signed-off-by: Yaniel Cabrera <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2161.
Description
In TestTimeAugmentation, I called
torch.cudaas a default argument to a constructor. This meant that the following code previously worked and now didn't:I fixed the problem and also created a unit test to avoid it happening in the future. The trick is that we shouldn't call
torch.cuda.duringimport monai.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.