Skip to content

delete set_visible_devices#2168

Merged
ericspod merged 2 commits intoProject-MONAI:devfrom
rijobro:2167-delete-set_visible_devices
May 10, 2021
Merged

delete set_visible_devices#2168
ericspod merged 2 commits intoProject-MONAI:devfrom
rijobro:2167-delete-set_visible_devices

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented May 10, 2021

Fixes #2167.

Description

Delete unused, untested function that doesn't appear to work.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested review from Nic-Ma and wyli May 10, 2021 13:12
@Nic-Ma Nic-Ma requested a review from ericspod May 10, 2021 14:10
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented May 10, 2021

Hi @ericspod ,

I think you added this utils function before, is it still useful in some tutorials or APIs?

Thanks.

@ericspod
Copy link
Copy Markdown
Member

What this function does is change the environment variable so it should still work if nothing that uses CUDA is instantiated before it's called. I had this here because I had the situation of having two different CUDA devices and didn't want to use the first one which was used for display. It's hard to test this sort of thing and no one's mentioned using it so it can go.

@ericspod ericspod enabled auto-merge (squash) May 10, 2021 16:48
@ericspod ericspod merged commit eca3f19 into Project-MONAI:dev May 10, 2021
@rijobro rijobro deleted the 2167-delete-set_visible_devices branch May 12, 2021 14:29
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
Signed-off-by: Richard Brown <[email protected]>

Co-authored-by: Eric Kerfoot <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
Signed-off-by: Richard Brown <[email protected]>

Co-authored-by: Eric Kerfoot <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
wyli pushed a commit that referenced this pull request May 26, 2021
Signed-off-by: Richard Brown <[email protected]>

Co-authored-by: Eric Kerfoot <[email protected]>
wyli pushed a commit that referenced this pull request May 26, 2021
Signed-off-by: Richard Brown <[email protected]>

Co-authored-by: Eric Kerfoot <[email protected]>
wyli pushed a commit that referenced this pull request May 26, 2021
Signed-off-by: Richard Brown <[email protected]>

Co-authored-by: Eric Kerfoot <[email protected]>
wyli pushed a commit that referenced this pull request May 26, 2021
Signed-off-by: Richard Brown <[email protected]>

Co-authored-by: Eric Kerfoot <[email protected]>
wyli pushed a commit that referenced this pull request May 26, 2021
Signed-off-by: Richard Brown <[email protected]>

Co-authored-by: Eric Kerfoot <[email protected]>
wyli pushed a commit that referenced this pull request May 27, 2021
Signed-off-by: Richard Brown <[email protected]>

Co-authored-by: Eric Kerfoot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

delete set_visible_devices?

3 participants