Merged
Conversation
Signed-off-by: Yiheng Wang <[email protected]>
Contributor
|
Hi @ericspod , Could you please help review this PR as you developed this layer factory before? I think you know more details. Thanks in advance. |
Nic-Ma
reviewed
May 12, 2021
ericspod
reviewed
May 12, 2021
Member
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
This is a good improvement and using the factories the way I think we should. There's a few comments to address but then we can approve.
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
wyli
approved these changes
May 14, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks! this PR introduces breaking changes for SegResNet, removed norm_name and num_groups parameters, added act and norm parameter. but the default behaviour doesn't change.
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* enhance norm and act layers Signed-off-by: Yiheng Wang <[email protected]> * write generic norm and act layers Signed-off-by: Yiheng Wang <[email protected]> * Fix flake8 errors Signed-off-by: Yiheng Wang <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* enhance norm and act layers Signed-off-by: Yiheng Wang <[email protected]> * write generic norm and act layers Signed-off-by: Yiheng Wang <[email protected]> * Fix flake8 errors Signed-off-by: Yiheng Wang <[email protected]>
This was referenced Aug 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang [email protected]
Fixes #2164 .
Description
Enhance norm and act layers for segresnet and dynunet.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.