Skip to content

2154 - Revert workaround "Pytype fix (#2153)"#2157

Merged
wyli merged 1 commit intoProject-MONAI:devfrom
wyli:2154-remove-attrs-workaround
May 7, 2021
Merged

2154 - Revert workaround "Pytype fix (#2153)"#2157
wyli merged 1 commit intoProject-MONAI:devfrom
wyli:2154-remove-attrs-workaround

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented May 7, 2021

This reverts commit 9c62769.

Signed-off-by: Wenqi Li [email protected]

Fixes #2154

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested a review from rijobro May 7, 2021 08:04
Copy link
Copy Markdown
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I see they closed the pytype issue by fixing their attrs version. Thanks!

@wyli wyli enabled auto-merge (squash) May 7, 2021 08:30
@wyli wyli merged commit 2a4c9e5 into Project-MONAI:dev May 7, 2021
@wyli wyli deleted the 2154-remove-attrs-workaround branch May 7, 2021 08:58
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 10, 2021
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove attrs from pip requirements

2 participants