Skip to content

2150 2152 Enhance metrics summary report#2156

Merged
wyli merged 10 commits intoProject-MONAI:devfrom
Nic-Ma:2150-enhance-metrics-report
May 7, 2021
Merged

2150 2152 Enhance metrics summary report#2156
wyli merged 10 commits intoProject-MONAI:devfrom
Nic-Ma:2150-enhance-metrics-report

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented May 7, 2021

Fixes #2150 #2152 .

Description

This PR:

  1. added notnans count to the metrics summary report。
  2. enhanced the doc-strings.
  3. add support to set percent value.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma force-pushed the 2150-enhance-metrics-report branch from 00f7781 to ed3665d Compare May 7, 2021 03:44
@Nic-Ma Nic-Ma force-pushed the 2150-enhance-metrics-report branch from d5066fa to d54f586 Compare May 7, 2021 09:19
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 7, 2021

/black

@Nic-Ma Nic-Ma changed the title 2150 Enhance metrics summary report 2150 2152 Enhance metrics summary report May 7, 2021
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! we should replace percent with percentile in this PR

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 7, 2021

/black

@wyli wyli merged commit bf5a7e9 into Project-MONAI:dev May 7, 2021
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 10, 2021
* [DLMED] add notnans to summary

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix bug in the dist test

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] enhance the percent

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] update tests

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

Co-authored-by: monai-bot <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
* [DLMED] add notnans to summary

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix bug in the dist test

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] enhance the percent

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] update tests

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

Co-authored-by: monai-bot <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
* [DLMED] add notnans to summary

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix bug in the dist test

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] enhance the percent

Signed-off-by: Nic Ma <[email protected]>

* [MONAI] python code formatting

Signed-off-by: monai-bot <[email protected]>

* [DLMED] update tests

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

Co-authored-by: monai-bot <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
@Nic-Ma Nic-Ma deleted the 2150-enhance-metrics-report branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sample count in metric_summary report

3 participants