Skip to content

Pytype fix#2153

Merged
wyli merged 4 commits intoProject-MONAI:devfrom
rijobro:pytype_fix
May 6, 2021
Merged

Pytype fix#2153
wyli merged 4 commits intoProject-MONAI:devfrom
rijobro:pytype_fix

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented May 6, 2021

Fixes #2121 (comment).

Description

Avoid most recent pytype (2021.05.04) due to google/pytype#909.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

rijobro added 2 commits May 6, 2021 16:58
@rijobro
skip most recent pytype
adc11df 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
avoid pytype 2021.05.04
8dbcc8d 
Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested a review from wyli May 6, 2021 16:03
wyli
wyli approved these changes May 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks this is nice

@wyli wyli enabled auto-merge (squash) May 6, 2021 16:04
@rijobro
pytype<2021
832831e 
Signed-off-by: Richard Brown <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 6, 2021

according to the pytype ticket, looks like it's actually the attrs issue... https://github.com/python-attrs/attrs/releases

@wyli wyli disabled auto-merge May 6, 2021 16:17
@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented May 6, 2021

Ok. So we add in attrs<21.1.0 before pytype and then remove it once their issue is closed?

@rijobro
old attrs
d298420 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented May 6, 2021

Also looks like the attrs bug has already been fixed, so the problem will solve itself when they do their next release.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 6, 2021

Also looks like the attrs bug has already been fixed, so the problem will solve itself when they do their next release.

shall we close this and wait?

@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented May 6, 2021

no, we have no idea when they'll release the next tag, I think we should merge and then revert when possible. Otherwise we can't merge any other PRs in the meantime.

@wyli wyli enabled auto-merge (squash) May 6, 2021 16:34
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 6, 2021

sounds good

@rijobro rijobro mentioned this pull request May 6, 2021
Closed
@wyli wyli merged commit 9c62769 into Project-MONAI:dev May 6, 2021
wyli added a commit that referenced this pull request May 7, 2021
@wyli
Revert "Pytype fix (#2153)"
526cab6 
This reverts commit 9c62769.
wyli added a commit to wyli/MONAI that referenced this pull request May 7, 2021
@wyli
Revert "Pytype fix (Project-MONAI#2153)"
15001a0 
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
@rijobro rijobro deleted the pytype_fix branch May 7, 2021 08:24
wyli added a commit that referenced this pull request May 7, 2021
@wyli
Revert "Pytype fix (#2153)" (#2157)
2a4c9e5 
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 10, 2021
@rijobro @yanielc
Pytype fix (Project-MONAI#2153)
e47c250 
* skip most recent pytype

Signed-off-by: Richard Brown <[email protected]>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <[email protected]>

* pytype<2021

Signed-off-by: Richard Brown <[email protected]>

* old attrs

Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 10, 2021
@wyli @yanielc
Revert "Pytype fix (Project-MONAI#2153)" (Project-MONAI#2157)
4b44c70 
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
@rijobro @yanielc
Pytype fix (Project-MONAI#2153)
2a3d749 
* skip most recent pytype

Signed-off-by: Richard Brown <[email protected]>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <[email protected]>

* pytype<2021

Signed-off-by: Richard Brown <[email protected]>

* old attrs

Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
@wyli @yanielc
Revert "Pytype fix (Project-MONAI#2153)" (Project-MONAI#2157)
7cf24d2 
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
@rijobro @yanielc
Pytype fix (Project-MONAI#2153)
d659f4a 
* skip most recent pytype

Signed-off-by: Richard Brown <[email protected]>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <[email protected]>

* pytype<2021

Signed-off-by: Richard Brown <[email protected]>

* old attrs

Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
@wyli @yanielc
Revert "Pytype fix (Project-MONAI#2153)" (Project-MONAI#2157)
7084d46 
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
@rijobro @yanielc
Pytype fix (Project-MONAI#2153)
32a8a6d 
* skip most recent pytype

Signed-off-by: Richard Brown <[email protected]>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <[email protected]>

* pytype<2021

Signed-off-by: Richard Brown <[email protected]>

* old attrs

Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
@wyli @yanielc
Revert "Pytype fix (Project-MONAI#2153)" (Project-MONAI#2157)
6e2aae7 
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
@rijobro @yanielc
Pytype fix (Project-MONAI#2153)
fac06a6 
* skip most recent pytype

Signed-off-by: Richard Brown <[email protected]>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <[email protected]>

* pytype<2021

Signed-off-by: Richard Brown <[email protected]>

* old attrs

Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
@wyli @yanielc
Revert "Pytype fix (Project-MONAI#2153)" (Project-MONAI#2157)
9e6e4cf 
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
@rijobro @yanielc
Pytype fix (Project-MONAI#2153)
8bb7438 
* skip most recent pytype

Signed-off-by: Richard Brown <[email protected]>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <[email protected]>

* pytype<2021

Signed-off-by: Richard Brown <[email protected]>

* old attrs

Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
@wyli @yanielc
Revert "Pytype fix (Project-MONAI#2153)" (Project-MONAI#2157)
79540bd 
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
wyli pushed a commit that referenced this pull request May 26, 2021
@rijobro @wyli
Pytype fix (#2153)
e71e7ea 
* skip most recent pytype

Signed-off-by: Richard Brown <[email protected]>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <[email protected]>

* pytype<2021

Signed-off-by: Richard Brown <[email protected]>

* old attrs

Signed-off-by: Richard Brown <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
@wyli
Revert "Pytype fix (#2153)" (#2157)
8276fd0 
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
wyli pushed a commit that referenced this pull request May 26, 2021
@rijobro @wyli
Pytype fix (#2153)
8a61e2c 
* skip most recent pytype

Signed-off-by: Richard Brown <[email protected]>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <[email protected]>

* pytype<2021

Signed-off-by: Richard Brown <[email protected]>

* old attrs

Signed-off-by: Richard Brown <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
@wyli
Revert "Pytype fix (#2153)" (#2157)
bc2a10d 
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
wyli pushed a commit that referenced this pull request May 26, 2021
@rijobro @wyli
Pytype fix (#2153)
ab872cd 
* skip most recent pytype

Signed-off-by: Richard Brown <[email protected]>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <[email protected]>

* pytype<2021

Signed-off-by: Richard Brown <[email protected]>

* old attrs

Signed-off-by: Richard Brown <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
@wyli
Revert "Pytype fix (#2153)" (#2157)
06b0732 
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
wyli pushed a commit that referenced this pull request May 26, 2021
@rijobro @wyli
Pytype fix (#2153)
2b8957f 
* skip most recent pytype

Signed-off-by: Richard Brown <[email protected]>

* avoid pytype 2021.05.04

Signed-off-by: Richard Brown <[email protected]>

* pytype<2021

Signed-off-by: Richard Brown <[email protected]>

* old attrs

Signed-off-by: Richard Brown <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
@wyli
Revert "Pytype fix (#2153)" (#2157)
e0975f7 
This reverts commit 9c62769.

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rijobro @wyli