Merged
Conversation
Signed-off-by: Richard Brown <[email protected]>
Contributor
Author
|
When debugging, I put a print statement to verify that the first unit test skips the resampling, as expected. |
Contributor
|
thanks, need something like if not self.rand_affine.do_transform and self.rand_affine.spatial_size is None:
for idx, key in enumerate(self.keys):
if self.rand_affine.resampler.as_tensor_output:
d[key] = torch.tensor(key)
elif torch.is_tensor(d[key]):
d[key] = d[key].cpu().numpy()
return dfor need to double-check the output data type, make sure that the PR doesn't change the dtype for integer |
Contributor
Author
|
also need to think about the inverse for |
Contributor
Author
|
@wyli why would the dtype change if the image isn't modified? Because of the torch/numpy conversion? |
Signed-off-by: Richard Brown <[email protected]>
Contributor
|
the root cause is that the current resampling requires floats... MONAI/monai/transforms/spatial/array.py Lines 1240 to 1242 in 41e62e5 if we bypass the resample step, I feel the datatype might be different, but I haven't checked all the details... |
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Contributor
|
the dev branch had its 1024th merged pull request 🎉 |
Contributor
Author
|
that was quick, it's only a few weeks old! 😅 |
yanielc
pushed a commit
to yanielc/MONAI
that referenced
this pull request
May 10, 2021
* skip RandAffine if possible Signed-off-by: Richard Brown <[email protected]> * add randaffined Signed-off-by: Richard Brown <[email protected]> * mypy fix Signed-off-by: Richard Brown <[email protected]> * check consistency Signed-off-by: Richard Brown <[email protected]> Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc
pushed a commit
to yanielc/MONAI
that referenced
this pull request
May 13, 2021
* skip RandAffine if possible Signed-off-by: Richard Brown <[email protected]> * add randaffined Signed-off-by: Richard Brown <[email protected]> * mypy fix Signed-off-by: Richard Brown <[email protected]> * check consistency Signed-off-by: Richard Brown <[email protected]> Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc
pushed a commit
to yanielc/MONAI
that referenced
this pull request
May 13, 2021
* skip RandAffine if possible Signed-off-by: Richard Brown <[email protected]> * add randaffined Signed-off-by: Richard Brown <[email protected]> * mypy fix Signed-off-by: Richard Brown <[email protected]> * check consistency Signed-off-by: Richard Brown <[email protected]> Signed-off-by: Yaniel Cabrera <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* skip RandAffine if possible Signed-off-by: Richard Brown <[email protected]> * add randaffined Signed-off-by: Richard Brown <[email protected]> * mypy fix Signed-off-by: Richard Brown <[email protected]> * check consistency Signed-off-by: Richard Brown <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* skip RandAffine if possible Signed-off-by: Richard Brown <[email protected]> * add randaffined Signed-off-by: Richard Brown <[email protected]> * mypy fix Signed-off-by: Richard Brown <[email protected]> * check consistency Signed-off-by: Richard Brown <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* skip RandAffine if possible Signed-off-by: Richard Brown <[email protected]> * add randaffined Signed-off-by: Richard Brown <[email protected]> * mypy fix Signed-off-by: Richard Brown <[email protected]> * check consistency Signed-off-by: Richard Brown <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* skip RandAffine if possible Signed-off-by: Richard Brown <[email protected]> * add randaffined Signed-off-by: Richard Brown <[email protected]> * mypy fix Signed-off-by: Richard Brown <[email protected]> * check consistency Signed-off-by: Richard Brown <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* skip RandAffine if possible Signed-off-by: Richard Brown <[email protected]> * add randaffined Signed-off-by: Richard Brown <[email protected]> * mypy fix Signed-off-by: Richard Brown <[email protected]> * check consistency Signed-off-by: Richard Brown <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 27, 2021
* skip RandAffine if possible Signed-off-by: Richard Brown <[email protected]> * add randaffined Signed-off-by: Richard Brown <[email protected]> * mypy fix Signed-off-by: Richard Brown <[email protected]> * check consistency Signed-off-by: Richard Brown <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 27, 2021
* skip RandAffine if possible Signed-off-by: Richard Brown <[email protected]> * add randaffined Signed-off-by: Richard Brown <[email protected]> * mypy fix Signed-off-by: Richard Brown <[email protected]> * check consistency Signed-off-by: Richard Brown <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 27, 2021
* skip RandAffine if possible Signed-off-by: Richard Brown <[email protected]> * add randaffined Signed-off-by: Richard Brown <[email protected]> * mypy fix Signed-off-by: Richard Brown <[email protected]> * check consistency Signed-off-by: Richard Brown <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2124.
Description
Skip RandAffine if possible.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.