2146 Enhance PersistentDataset with shutil.move#2147
Merged
Nic-Ma merged 6 commits intoProject-MONAI:devfrom May 7, 2021
Merged
2146 Enhance PersistentDataset with shutil.move#2147Nic-Ma merged 6 commits intoProject-MONAI:devfrom
shutil.move#2147Nic-Ma merged 6 commits intoProject-MONAI:devfrom
Conversation
Contributor
Author
|
/black |
Signed-off-by: monai-bot <[email protected]>
wyli
approved these changes
May 6, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
looks good to me, need the internal verification I think
YuanTingHsieh
approved these changes
May 7, 2021
Collaborator
YuanTingHsieh
left a comment
YuanTingHsieh
left a comment
There was a problem hiding this comment.
LGTM, internal test passed
yanielc
pushed a commit
to yanielc/MONAI
that referenced
this pull request
May 10, 2021
* [DLMED] use shutil.move instead Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> Co-authored-by: monai-bot <[email protected]> Co-authored-by: Wenqi Li <[email protected]> Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc
pushed a commit
to yanielc/MONAI
that referenced
this pull request
May 13, 2021
* [DLMED] use shutil.move instead Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> Co-authored-by: monai-bot <[email protected]> Co-authored-by: Wenqi Li <[email protected]> Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc
pushed a commit
to yanielc/MONAI
that referenced
this pull request
May 13, 2021
* [DLMED] use shutil.move instead Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> Co-authored-by: monai-bot <[email protected]> Co-authored-by: Wenqi Li <[email protected]> Signed-off-by: Yaniel Cabrera <[email protected]>
wyli
added a commit
that referenced
this pull request
May 26, 2021
* [DLMED] use shutil.move instead Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> Co-authored-by: monai-bot <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
May 26, 2021
* [DLMED] use shutil.move instead Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> Co-authored-by: monai-bot <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
May 26, 2021
* [DLMED] use shutil.move instead Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> Co-authored-by: monai-bot <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
May 26, 2021
* [DLMED] use shutil.move instead Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> Co-authored-by: monai-bot <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
May 26, 2021
* [DLMED] use shutil.move instead Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> Co-authored-by: monai-bot <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
May 27, 2021
* [DLMED] use shutil.move instead Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> Co-authored-by: monai-bot <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
May 27, 2021
* [DLMED] use shutil.move instead Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> Co-authored-by: monai-bot <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
May 27, 2021
* [DLMED] use shutil.move instead Signed-off-by: Nic Ma <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]> Co-authored-by: monai-bot <[email protected]> Co-authored-by: Wenqi Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2146 .
Description
This PR replaced the
os.movewithshutil.movein PersistentDataset.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.