Skip to content

Temporarily changing crf test to allow some errors#2135

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
charliebudd:phl-fix
May 4, 2021
Merged

Temporarily changing crf test to allow some errors#2135
wyli merged 3 commits intoProject-MONAI:devfrom
charliebudd:phl-fix

Conversation

@charliebudd
Copy link
Copy Markdown
Collaborator

Signed-off-by: chaliebudd [email protected]

Fixes #2023 .

Description

Bug currently under investigation is causing the output of the CRF to vary. This should allow the test to pass under these cases while a solution is found.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix... only see the error once in 20+ runs, still not sure about the root cause

@wyli wyli enabled auto-merge (squash) May 4, 2021 11:02
@wyli wyli merged commit 7ef0142 into Project-MONAI:dev May 4, 2021
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 10, 2021
* Temporarily changing crf test to allow some errors

Signed-off-by: chaliebudd <[email protected]>

* changing to unittest assert

Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
* Temporarily changing crf test to allow some errors

Signed-off-by: chaliebudd <[email protected]>

* changing to unittest assert

Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
* Temporarily changing crf test to allow some errors

Signed-off-by: chaliebudd <[email protected]>

* changing to unittest assert

Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
* Temporarily changing crf test to allow some errors

Signed-off-by: chaliebudd <[email protected]>

* changing to unittest assert

Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
* Temporarily changing crf test to allow some errors

Signed-off-by: chaliebudd <[email protected]>

* changing to unittest assert

Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
* Temporarily changing crf test to allow some errors

Signed-off-by: chaliebudd <[email protected]>

* changing to unittest assert

Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
* Temporarily changing crf test to allow some errors

Signed-off-by: chaliebudd <[email protected]>

* changing to unittest assert

Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
* Temporarily changing crf test to allow some errors

Signed-off-by: chaliebudd <[email protected]>

* changing to unittest assert

Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 27, 2021
* Temporarily changing crf test to allow some errors

Signed-off-by: chaliebudd <[email protected]>

* changing to unittest assert

Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 27, 2021
* Temporarily changing crf test to allow some errors

Signed-off-by: chaliebudd <[email protected]>

* changing to unittest assert

Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 27, 2021
* Temporarily changing crf test to allow some errors

Signed-off-by: chaliebudd <[email protected]>

* changing to unittest assert

Signed-off-by: chaliebudd <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRFTestCaseCuda test case issue

2 participants