Skip to content

create meta data key if necessary#2119

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
rijobro:create_affine_meta_data_dict
Apr 30, 2021
Merged

create meta data key if necessary#2119
wyli merged 2 commits intoProject-MONAI:devfrom
rijobro:create_affine_meta_data_dict

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Apr 30, 2021

Not all images will have been read from file, meaning img_meta_data won't necessarily be present. The user may still want to change voxel spacing, in which case the original affine is assumed to be identity. However, previously an error would be thrown if the meta data wasn't present. Here, we create it if necessary.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • Documentation updated, tested make html command in the docs/ folder.

rijobro added 2 commits April 30, 2021 13:51
Signed-off-by: Richard Brown <[email protected]>
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli enabled auto-merge (squash) April 30, 2021 13:56
@wyli wyli merged commit d93df0e into Project-MONAI:dev Apr 30, 2021
@rijobro rijobro deleted the create_affine_meta_data_dict branch April 30, 2021 14:17
wyli pushed a commit that referenced this pull request May 26, 2021
* create meta data key if necessary

Signed-off-by: Richard Brown <[email protected]>

* add orientationd too

Signed-off-by: Richard Brown <[email protected]>
wyli pushed a commit that referenced this pull request May 26, 2021
* create meta data key if necessary

Signed-off-by: Richard Brown <[email protected]>

* add orientationd too

Signed-off-by: Richard Brown <[email protected]>
wyli pushed a commit that referenced this pull request May 26, 2021
* create meta data key if necessary

Signed-off-by: Richard Brown <[email protected]>

* add orientationd too

Signed-off-by: Richard Brown <[email protected]>
wyli pushed a commit that referenced this pull request May 27, 2021
* create meta data key if necessary

Signed-off-by: Richard Brown <[email protected]>

* add orientationd too

Signed-off-by: Richard Brown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants