Skip to content

2111 - adds a map_items option to compose#2112

Merged
ericspod merged 3 commits intoProject-MONAI:devfrom
wyli:2111-compose-map
Apr 30, 2021
Merged

2111 - adds a map_items option to compose#2112
ericspod merged 3 commits intoProject-MONAI:devfrom
wyli:2111-compose-map

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Apr 29, 2021

Signed-off-by: Wenqi Li [email protected]

Fixes #2111

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.

@wyli wyli requested review from Nic-Ma, ericspod and rijobro April 29, 2021 19:13
@wyli
update compose
ff0892e 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 2111-compose-map branch from b5fdb99 to ff0892e Compare April 29, 2021 19:36
@wyli wyli changed the title add map_items option to compose 2111 - adds a map_items option to compose Apr 29, 2021
ericspod
ericspod reviewed Apr 29, 2021
View reviewed changes
@wyli wyli requested a review from ericspod April 29, 2021 20:26
@ericspod ericspod enabled auto-merge (squash) April 29, 2021 20:28
@wyli wyli disabled auto-merge April 29, 2021 20:49
@wyli wyli enabled auto-merge (squash) April 29, 2021 22:34
@ericspod ericspod disabled auto-merge April 29, 2021 22:41
@ericspod ericspod enabled auto-merge (squash) April 29, 2021 22:41
@ericspod ericspod merged commit 198cd2f into Project-MONAI:dev Apr 30, 2021
@wyli wyli deleted the 2111-compose-map branch April 30, 2021 14:03
wyli added a commit that referenced this pull request May 26, 2021
@wyli
2111 - adds a map_items option to compose (#2112)
654ead4 
* update compose

Signed-off-by: Wenqi Li <[email protected]>

* update based on comments

Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
@wyli
2111 - adds a map_items option to compose (#2112)
5e868d6 
* update compose

Signed-off-by: Wenqi Li <[email protected]>

* update based on comments

Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
@wyli
2111 - adds a map_items option to compose (#2112)
01f3fbd 
* update compose

Signed-off-by: Wenqi Li <[email protected]>

* update based on comments

Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 26, 2021
@wyli
2111 - adds a map_items option to compose (#2112)
4ec9f1f 
* update compose

Signed-off-by: Wenqi Li <[email protected]>

* update based on comments

Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 27, 2021
@wyli
2111 - adds a map_items option to compose (#2112)
fc79432 
* update compose

Signed-off-by: Wenqi Li <[email protected]>

* update based on comments

Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 27, 2021
@wyli
2111 - adds a map_items option to compose (#2112)
2c2b7e3 
* update compose

Signed-off-by: Wenqi Li <[email protected]>

* update based on comments

Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request May 27, 2021
@wyli
2111 - adds a map_items option to compose (#2112)
98cb0e3 
* update compose

Signed-off-by: Wenqi Li <[email protected]>

* update based on comments

Signed-off-by: Wenqi Li <[email protected]>
@ibro45
Copy link
Copy Markdown
Contributor

ibro45 commented Mar 18, 2024 •
edited
Loading

Would a more granular approach be possible? To allow controlling map_items at the individual transform level instead of at the Compose level.
I tried defining a Compose within a Compose with different map_items, but it did not operate differently from the parent Compose.

This granular behavior would be enabled if Transform/MapTransform had a map_items argument.

Would this be something of interest? If yes, I'll make an issue and see if I can do a PR for it.

@ericspod
Copy link
Copy Markdown
Member

ericspod commented Mar 21, 2024

Would this be something of interest? If yes, I'll make an issue and see if I can do a PR for it.

Hi @ibro45 I'm not sure if there would be interest or not, I don't think I personally would use this off the top of my head, but if you want to create an issue we can discuss it. I suspect there will be quite a lot of changes to a lot of transforms to do this but let's see. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ArrayDataset only applies same transform if transforms match

3 participants

@wyli @ibro45 @ericspod