Skip to content

only pip install cucim if on linux#2106

Merged
rijobro merged 2 commits intoProject-MONAI:devfrom
rijobro:cucim_linux
Apr 28, 2021
Merged

only pip install cucim if on linux#2106
rijobro merged 2 commits intoProject-MONAI:devfrom
rijobro:cucim_linux

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Apr 28, 2021

Description

Only pip install cucim if on linux. The requirements-dev.txt, as it currently stands, causes an error on non-linux machines, meaning that following requirements don't get installed.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@rijobro rijobro requested review from Nic-Ma and wyli April 28, 2021 10:52
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! didn't know this syntax

@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented Apr 28, 2021

For interest: https://www.python.org/dev/peps/pep-0508/#environment-markers

@rijobro rijobro enabled auto-merge (squash) April 28, 2021 10:58
@rijobro rijobro merged commit 304d1a8 into Project-MONAI:dev Apr 28, 2021
@wyli wyli mentioned this pull request May 4, 2021
1 task
@rijobro rijobro deleted the cucim_linux branch May 4, 2021 10:37
wyli pushed a commit that referenced this pull request May 26, 2021
wyli pushed a commit that referenced this pull request May 26, 2021
wyli pushed a commit that referenced this pull request May 26, 2021
wyli pushed a commit that referenced this pull request May 27, 2021
wyli pushed a commit that referenced this pull request May 27, 2021
wyli pushed a commit that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants