Adding error messaging for unsupported tensor shapes#2089
Merged
wyli merged 4 commits intoProject-MONAI:masterfrom Apr 27, 2021
Merged
Adding error messaging for unsupported tensor shapes#2089wyli merged 4 commits intoProject-MONAI:masterfrom
wyli merged 4 commits intoProject-MONAI:masterfrom
Conversation
Signed-off-by: chaliebudd <[email protected]>
Contributor
|
/black |
Signed-off-by: monai-bot <[email protected]>
wyli
approved these changes
Apr 27, 2021
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* adding error messaging for unsupported tensor shapes Signed-off-by: chaliebudd <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* adding error messaging for unsupported tensor shapes Signed-off-by: chaliebudd <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
* adding error messaging for unsupported tensor shapes Signed-off-by: chaliebudd <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 27, 2021
* adding error messaging for unsupported tensor shapes Signed-off-by: chaliebudd <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 27, 2021
* adding error messaging for unsupported tensor shapes Signed-off-by: chaliebudd <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 27, 2021
* adding error messaging for unsupported tensor shapes Signed-off-by: chaliebudd <[email protected]> * [MONAI] python code formatting Signed-off-by: monai-bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chaliebudd [email protected]
Address an issue raised in #2077/#2083 where some tensor shapes cause the filtering to silently fail. Errors have been added to explain that these shapes are unsupported.
P.S. A move to JIT compilation will allow us to provide optimised code that is more flexible in this regard.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.