Skip to content

Adding Regression Evaluation Metrics#2084

Merged
wyli merged 13 commits intoProject-MONAI:devfrom
masadcv:1127-regression-metrics
May 8, 2021
Merged

Adding Regression Evaluation Metrics#2084
wyli merged 13 commits intoProject-MONAI:devfrom
masadcv:1127-regression-metrics

Conversation

@masadcv
Copy link
Copy Markdown
Contributor

@masadcv masadcv commented Apr 24, 2021

Signed-off-by: masadcv [email protected]

Partially Fixes Project-MONAI/MetricsReloaded#40 .

Description

Proposal implementation for Regression Evaluation metrics.

This pull request includes the following evaluation metrics:

In addition to metrics classes, relevant handlers have been added for each metric inheriting from IterationMetric class.
A unittest file has also been added to cover the new features in testing.
Docstrings as well as relevant docs (metrics/handlers) have been updated with addition of the new metrics/handlers.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@masadcv masadcv changed the title [WIP] Adding Regression Metrics [WIP] Adding Regression Evaluation Metrics Apr 24, 2021
@masadcv masadcv changed the title [WIP] Adding Regression Evaluation Metrics Adding Regression Evaluation Metrics May 3, 2021
@masadcv masadcv marked this pull request as ready for review May 3, 2021 21:35
@masadcv
Copy link
Copy Markdown
Contributor Author

masadcv commented May 3, 2021

Hi @Nic-Ma , @wyli this is now ready for review.

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!

@wyli wyli merged commit e977596 into Project-MONAI:dev May 8, 2021
@masadcv masadcv deleted the 1127-regression-metrics branch May 8, 2021 20:41
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 10, 2021
* adding proposal implementation for reg. metrics

Signed-off-by: masadcv <[email protected]>

* add ignite wrappers regression metrics, needs test

Signed-off-by: masadcv <[email protected]>

* refactoring and adding docstrings with equations

Signed-off-by: masadcv <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
* adding proposal implementation for reg. metrics

Signed-off-by: masadcv <[email protected]>

* add ignite wrappers regression metrics, needs test

Signed-off-by: masadcv <[email protected]>

* refactoring and adding docstrings with equations

Signed-off-by: masadcv <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
* adding proposal implementation for reg. metrics

Signed-off-by: masadcv <[email protected]>

* add ignite wrappers regression metrics, needs test

Signed-off-by: masadcv <[email protected]>

* refactoring and adding docstrings with equations

Signed-off-by: masadcv <[email protected]>
Signed-off-by: Yaniel Cabrera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluation metrics - Regression / Generative models

2 participants