Skip to content

2051 Add support to K divisible crop in CropForeground#2064

Merged
Nic-Ma merged 13 commits intoProject-MONAI:masterfrom
Nic-Ma:2051-divisible-crop
Apr 23, 2021
Merged

2051 Add support to K divisible crop in CropForeground#2064
Nic-Ma merged 13 commits intoProject-MONAI:masterfrom
Nic-Ma:2051-divisible-crop

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Apr 21, 2021

Fixes #2051 .

Description

This PR added support to make the output of CropForeground to be K divisible.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli April 21, 2021 17:18
Nic-Ma added 2 commits April 22, 2021 01:36
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 22, 2021

/black

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just need to confirm the integration tests

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 23, 2021

/integration-test

@Nic-Ma Nic-Ma enabled auto-merge (squash) April 23, 2021 02:38
@Nic-Ma Nic-Ma merged commit f843d66 into Project-MONAI:master Apr 23, 2021
@Nic-Ma Nic-Ma deleted the 2051-divisible-crop branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CropForeground with divisible-size bounding boxes

2 participants