Skip to content

2045 2058 Add support device arg in TransformInverter#2062

Merged
Nic-Ma merged 7 commits intoProject-MONAI:masterfrom
Nic-Ma:2045-add-support-invert-device
Apr 21, 2021
Merged

2045 2058 Add support device arg in TransformInverter#2062
Nic-Ma merged 7 commits intoProject-MONAI:masterfrom
Nic-Ma:2045-add-support-invert-device

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Apr 21, 2021 •
edited
Loading

Fixes #2045 #2058 .

Description

This PR added support to set whether convert data to PyTorch Tensor and specify target device.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli April 21, 2021 04:32
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 21, 2021

could you address #2058 in this PR as well? they are potentially conflicting and should be verified together

@Nic-Ma Nic-Ma changed the title 2045 Add support device arg in TransformInverter 2045 2058 Add support device arg in TransformInverter Apr 21, 2021
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2021

could you address #2058 in this PR as well? they are potentially conflicting and should be verified together

Sure, I updated the PR to cover #2058 now, could you please help review it again?

Thanks in advance.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2021

/black

wyli
wyli approved these changes Apr 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2021

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) April 21, 2021 11:14
@Nic-Ma Nic-Ma merged commit ac47032 into Project-MONAI:master Apr 21, 2021
@wyli wyli mentioned this pull request Apr 22, 2021
Closed
@Nic-Ma Nic-Ma deleted the 2045-add-support-invert-device branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support to move data to device after inverting

2 participants

@Nic-Ma @wyli