Skip to content

2044 Add check for label data type#2060

Merged
Nic-Ma merged 5 commits intoProject-MONAI:masterfrom
Nic-Ma:2044-check-label
Apr 21, 2021
Merged

2044 Add check for label data type#2060
Nic-Ma merged 5 commits intoProject-MONAI:masterfrom
Nic-Ma:2044-check-label

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Apr 21, 2021

Fixes #2044 .

Description

Currently, we always move label data to device, but it can't work if the label is not a Tensor, this PR added type check.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli April 21, 2021 00:03
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 21, 2021

The test_integration_workflow test passed locally.
Thanks.

@Nic-Ma Nic-Ma merged commit 13bf996 into Project-MONAI:master Apr 21, 2021
@Nic-Ma Nic-Ma deleted the 2044-check-label branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ignore label in the workflow if it's not tensor

2 participants