Skip to content

2011 Add warning for resample in SegnmentationSaver#2013

Merged
Nic-Ma merged 5 commits intoProject-MONAI:masterfrom
Nic-Ma:2011-fix-invert-affine
Apr 15, 2021
Merged

2011 Add warning for resample in SegnmentationSaver#2013
Nic-Ma merged 5 commits intoProject-MONAI:masterfrom
Nic-Ma:2011-fix-invert-affine

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Apr 15, 2021

Fixes #2011 .

Description

This PR added warning message in SegmentationSaver handler to help users set correct arg.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 15, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli April 15, 2021 12:05
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Nic-Ma Nic-Ma enabled auto-merge (squash) April 15, 2021 12:53
@Nic-Ma Nic-Ma merged commit 88806e1 into Project-MONAI:master Apr 15, 2021
@Nic-Ma Nic-Ma deleted the 2011-fix-invert-affine branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inverse of SpacingD transform can't work with SegmentationSaver resample

3 participants