Skip to content

fix duplication of key_transforms in RandSpatialCropSamplesd#2010

Merged
wyli merged 7 commits intoProject-MONAI:masterfrom
rijobro:2009-fix-transform-duplication
Apr 21, 2021
Merged

fix duplication of key_transforms in RandSpatialCropSamplesd#2010
wyli merged 7 commits intoProject-MONAI:masterfrom
rijobro:2009-fix-transform-duplication

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Apr 15, 2021

Fixes #2009.

Description

Requires a deep copy to ensure that each of the samples are separate. Unit test added.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

@rijobro rijobro requested review from Nic-Ma and wyli April 15, 2021 08:39
@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented Apr 15, 2021

Not sure why it reports isort as failing. Locally, I get:

rbrown@rb-monai-0-0:~/MONAI$ ./runtests.sh --isort
...
--------------------------------------------------------------------------------
isort

                 _                 _
                (_) ___  ___  _ __| |_
                | |/ _/ / _ \/ '__  _/
                | |\__ \/\_\/| |  | |_
                |_|\___/\___/\_/   \_/

      isort your imports, so you don't have to.

                    VERSION 5.8.0

Skipped 5 files
passed!
rbrown@rb-monai-0-0:~/MONAI$ git status
On branch spatialcrop_slices
Your branch is up to date with 'rijobro/spatialcrop_slices'.

nothing to commit, working tree clean

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Apr 16, 2021

/black

it was not an isort error, the ci error is from black

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Apr 21, 2021

/black

@wyli wyli enabled auto-merge (squash) April 21, 2021 17:36
@wyli wyli merged commit 4a0aae8 into Project-MONAI:master Apr 21, 2021
@rijobro rijobro deleted the 2009-fix-transform-duplication branch May 4, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicated records of RandSpatialCropSamplesd in key_transforms in case of preceding transforms

5 participants