Skip to content

2007 Enhance the unit tests of MapLabelValue transform#2008

Merged
Nic-Ma merged 6 commits intoProject-MONAI:masterfrom
Nic-Ma:2007-enhance-maplabelvalue
Apr 14, 2021
Merged

2007 Enhance the unit tests of MapLabelValue transform#2008
Nic-Ma merged 6 commits intoProject-MONAI:masterfrom
Nic-Ma:2007-enhance-maplabelvalue

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Apr 14, 2021

Fixes #2007 .

Description

This PR added more tests to cover corner case of MapLabelValue.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma force-pushed the 2007-enhance-maplabelvalue branch from 254130a to 5fa92ff Compare April 14, 2021 15:50
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 14, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli April 14, 2021 15:50
@Nic-Ma Nic-Ma enabled auto-merge (squash) April 14, 2021 16:11
@Nic-Ma Nic-Ma force-pushed the 2007-enhance-maplabelvalue branch from ec4903f to 70fa20e Compare April 14, 2021 16:39
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 14, 2021

/black

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Nic-Ma Nic-Ma merged commit 5f47407 into Project-MONAI:master Apr 14, 2021
@Nic-Ma Nic-Ma deleted the 2007-enhance-maplabelvalue branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MapLabelValue is incorrect when mapping strings

3 participants