Skip to content

1985 Add SaliencyInferer#2006

Merged
Nic-Ma merged 10 commits intoProject-MONAI:masterfrom
Nic-Ma:1985-add-saliencyinferer
Apr 14, 2021
Merged

1985 Add SaliencyInferer#2006
Nic-Ma merged 10 commits intoProject-MONAI:masterfrom
Nic-Ma:1985-add-saliencyinferer

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Apr 14, 2021

Fixes #1985 .

Description

This PR added the SaliencyInferer to leverage GradCam module.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma marked this pull request as ready for review April 14, 2021 09:46
@Nic-Ma Nic-Ma changed the title [WIP] 1985 Add SaliencyInferer 1985 Add SaliencyInferer Apr 14, 2021
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli and removed request for wyli April 14, 2021 09:47
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 14, 2021

/black

Copy link
Copy Markdown
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! A few comments, feel free to use them or not.

Co-authored-by: Richard Brown <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma Nic-Ma force-pushed the 1985-add-saliencyinferer branch from f2c4bdb to b383104 Compare April 14, 2021 14:29
@Nic-Ma Nic-Ma enabled auto-merge (squash) April 14, 2021 14:33
@Nic-Ma Nic-Ma merged commit 2d8595d into Project-MONAI:master Apr 14, 2021
@Nic-Ma Nic-Ma deleted the 1985-add-saliencyinferer branch July 2, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SaliencyInferer

3 participants