Skip to content

TTA progress bar, use torch for mode, add label meta_data#1992

Merged
rijobro merged 7 commits intoProject-MONAI:masterfrom
rijobro:TTA_update
Apr 12, 2021
Merged

TTA progress bar, use torch for mode, add label meta_data#1992
rijobro merged 7 commits intoProject-MONAI:masterfrom
rijobro:TTA_update

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Apr 12, 2021

Description

A few updates to TTA:

  • Progress bar
  • Use torch for computing mode (quicker than numpy)
  • Include the meta_dict as this is required for the inverse of Orientationd, Spacingd, etc.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

rijobro added 4 commits April 12, 2021 12:49
@rijobro
TTA progress bar, use torch for mode, add label meta_data
b629eb9 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
autofix
3a9aeef 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
test no label
7024aff 
Signed-off-by: Richard Brown <[email protected]>
@rijobro
requires meta dict
7316aa6 
Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested review from Nic-Ma and wyli April 12, 2021 13:17
wyli
wyli approved these changes Apr 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could put the test in the min_test exclude cases

MONAI/tests/min_tests.py

Line 29 in b4d8780

exclude_cases = [ # these cases use external dependencies
min-depevnvironment doesn't have nibabel to run spacingd

@rijobro
add to min_tests
6f67cef 
Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro enabled auto-merge (squash) April 12, 2021 13:55
@rijobro rijobro merged commit b3eb73a into Project-MONAI:master Apr 12, 2021
wyli added a commit to wyli/MONAI that referenced this pull request Apr 12, 2021
@wyli
follow up of Project-MONAI#1992
1bf2ccd 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli mentioned this pull request Apr 12, 2021
Merged
1 task
wyli added a commit that referenced this pull request Apr 13, 2021
@wyli
include meta when inverting (#1997)
d72f61e 
* follow up of #1992

Signed-off-by: Wenqi Li <[email protected]>

* update spacing inverse

Signed-off-by: Wenqi Li <[email protected]>
@rijobro rijobro deleted the TTA_update branch April 13, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rijobro @wyli