remove unused RandomizableTransform#1952
Merged
wyli merged 2 commits intoProject-MONAI:masterfrom Apr 6, 2021
Merged
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/integration-test |
Contributor
|
@rijobro could you please help review this PR? Thanks in advance. |
Contributor
Author
|
verified that the integration tests work fine https://github.com/Project-MONAI/MONAI/actions/runs/721646680 |
rijobro
approved these changes
Apr 6, 2021
nsrivathsa
pushed a commit
to nsrivathsa/MONAI
that referenced
this pull request
Apr 12, 2021
Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: Neha Srivathsa <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes a few usage of
RandomizableTransform:RandomizableTransformbut doesn't initialise it (addresses "__init__method from the base class not called PYL-W0231")super().__init__(prob=1.0, do_transform=True), effectively not using theRandomizableTransform, therefore change to inheritRandomizablefor clarityRandomizableinstead ofRandomizableas the defining property__init__PYL-W0201"Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.