Merged
Conversation
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Contributor
|
could you please help review this? @Nic-Ma the NMS logic should be great, this is a refactoring to move the module from utils into transforms |
Nic-Ma
approved these changes
Apr 5, 2021
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me.
Thanks.
nsrivathsa
pushed a commit
to nsrivathsa/MONAI
that referenced
this pull request
Apr 12, 2021
* Add ProbNMS to transforts/post/array Signed-off-by: Behrooz <[email protected]> * Implement ProbNMSDict Signed-off-by: Behrooz <[email protected]> * Update the usage and add unittests Signed-off-by: Behrooz <[email protected]> * Update docs Signed-off-by: Behrooz <[email protected]> * Correct docs Signed-off-by: Behrooz <[email protected]> * Correct test case Signed-off-by: Behrooz <[email protected]> Co-authored-by: Wenqi Li <[email protected]> Signed-off-by: Neha Srivathsa <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
ProbNMSfrommonai/utilsand makes it a handler atmonai/transforms/postasProbNMSand ProbNMSd`. It also adds unittests.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.