Skip to content

Update prob map handler#1911

Merged
bhashemian merged 5 commits intoProject-MONAI:masterfrom
bhashemian:update_prob_map_handler
Apr 1, 2021
Merged

Update prob map handler#1911
bhashemian merged 5 commits intoProject-MONAI:masterfrom
bhashemian:update_prob_map_handler

Conversation

@bhashemian
Copy link
Copy Markdown
Member

@bhashemian bhashemian commented Mar 31, 2021

Description

This PR makes few improvements to ProbNMS and ProbMapProducer, including renaming and ignoring artifacts.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@bhashemian bhashemian requested a review from Nic-Ma March 31, 2021 22:42
@bhashemian bhashemian enabled auto-merge (squash) March 31, 2021 22:42
@bhashemian bhashemian requested a review from wyli April 1, 2021 02:34
@bhashemian bhashemian merged commit cd3c21a into Project-MONAI:master Apr 1, 2021
@bhashemian bhashemian deleted the update_prob_map_handler branch April 12, 2021 20:22
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
@bhashemian @nsrivathsa
Update prob map handler (Project-MONAI#1911)
71ce959 
* Rename the prob map producer unittest to match the module

Signed-off-by: Behrooz <[email protected]>

* Change probs_map to prob_map

Signed-off-by: Behrooz <[email protected]>

* Prepend image_inference_outputs with temp to be ignored

Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Neha Srivathsa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhashemian @wyli