Skip to content

Update Pathology Tests#1892

Merged
bhashemian merged 11 commits intoProject-MONAI:masterfrom
bhashemian:update_pathology_tests
Mar 30, 2021
Merged

Update Pathology Tests#1892
bhashemian merged 11 commits intoProject-MONAI:masterfrom
bhashemian:update_pathology_tests

Conversation

@bhashemian
Copy link
Copy Markdown
Member

@bhashemian bhashemian commented Mar 29, 2021

Description

Implement download_if_not_exist in tests/utils.py and update all the pathology tests that need to download the WSI test case.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@bhashemian bhashemian mentioned this pull request Mar 29, 2021
Merged
7 tasks
wyli
wyli reviewed Mar 29, 2021
View reviewed changes
@bhashemian
Revert "download_if_not_exist"
4c0dd36 
This reverts commit a4c65f3.

Signed-off-by: Behrooz <[email protected]>
@bhashemian
Update with download_url
90b2ee2 
Signed-off-by: Behrooz <[email protected]>
@bhashemian bhashemian force-pushed the update_pathology_tests branch from 354ae7c to 90b2ee2 Compare March 29, 2021 17:46
wyli
wyli approved these changes Mar 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 29, 2021

/black

@bhashemian bhashemian enabled auto-merge (squash) March 29, 2021 18:13
@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Mar 29, 2021

@wyli @Nic-Ma ,
I have seen PT18+CUDA112 is failing several times, is there any components that mainly causes this failure?
https://github.com/Project-MONAI/MONAI/pull/1892/checks?check_run_id=2221781586#step:6:8088

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 29, 2021

yes conflictions from multiple jobs trying to use the same GPU devices, there's no proper scheduling here for the github actions

@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Mar 29, 2021

@wyli @Nic-Ma, I see some housekeeping PRs are taking the resources while I have been waiting for more than 6 hours for pathology PRs to be merged and they are failing because of this. Can we hold on for a day on not urgent PRs?

@bhashemian bhashemian merged commit f8d9755 into Project-MONAI:master Mar 30, 2021
@bhashemian bhashemian deleted the update_pathology_tests branch April 12, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bhashemian @wyli @monai-bot