Skip to content

1833 Enhance the list collate function#1887

Merged
Nic-Ma merged 7 commits intoProject-MONAI:masterfrom
Nic-Ma:1833-improve-collate-msg
Mar 29, 2021
Merged

1833 Enhance the list collate function#1887
Nic-Ma merged 7 commits intoProject-MONAI:masterfrom
Nic-Ma:1833-improve-collate-msg

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Mar 29, 2021

Fixes #1833 .

Description

This PR enhanced the list collate function with more error information and unit tests.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 29, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli March 29, 2021 08:51
Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix

@Nic-Ma Nic-Ma force-pushed the 1833-improve-collate-msg branch from 0fc5f28 to 232e645 Compare March 29, 2021 10:34
@Nic-Ma Nic-Ma enabled auto-merge (squash) March 29, 2021 10:35
@Nic-Ma Nic-Ma merged commit 140b7cc into Project-MONAI:master Mar 29, 2021
@Nic-Ma Nic-Ma deleted the 1833-improve-collate-msg branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve list_data_collate error messages

3 participants