[WIP] 1872 Implement pathology eval froc class#1873
Closed
yiheng-wang-nv wants to merge 1 commit intoProject-MONAI:masterfrom
Closed
[WIP] 1872 Implement pathology eval froc class#1873yiheng-wang-nv wants to merge 1 commit intoProject-MONAI:masterfrom
yiheng-wang-nv wants to merge 1 commit intoProject-MONAI:masterfrom
Conversation
Signed-off-by: Yiheng Wang <[email protected]>
bhashemian
reviewed
Mar 28, 2021
Member
bhashemian
left a comment
bhashemian
left a comment
There was a problem hiding this comment.
@yiheng-wang-nv, thanks for your great work. I realized that this PR needed some design changes that requires the pathology domain knowledge, so I had to take over and reimplement it at #1878.
I am working on the unittests so you don't need to be worry about them.
Contributor
Author
Thanks @behxyz , I closed #1878 and I will review that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang [email protected]
Fixes #1872 .
Description
The unittest will be added after finishing the code review step.
Status
Work in progress
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.