Skip to content

[1859] fix lr finder#1865

Merged
rijobro merged 4 commits intoProject-MONAI:masterfrom
rijobro:1859_lr_finder
Mar 26, 2021
Merged

[1859] fix lr finder#1865
rijobro merged 4 commits intoProject-MONAI:masterfrom
rijobro:1859_lr_finder

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Mar 26, 2021

Fixes #1859

Description

Close plot after 3 secs

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

rijobro added 2 commits March 26, 2021 12:11
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I think this is better than the previous version. although it doesn't work in my case which is a remote linux with ssh X11 forwarding... the tests will try to send the figures via ssh

@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented Mar 26, 2021

Is there any way to programatically figure out if the figure would be sent over x11?

@rijobro rijobro enabled auto-merge (squash) March 26, 2021 16:35
@rijobro rijobro merged commit 32e6b12 into Project-MONAI:master Mar 26, 2021
@rijobro rijobro deleted the 1859_lr_finder branch May 4, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lr_finder plotting method automated unit tests

2 participants