Skip to content

infer spatial dims from input -- warp#1860

Merged
wyli merged 1 commit intoProject-MONAI:masterfrom
wyli:infer-spatial-dims-warp
Mar 26, 2021
Merged

infer spatial dims from input -- warp#1860
wyli merged 1 commit intoProject-MONAI:masterfrom
wyli:infer-spatial-dims-warp

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Mar 26, 2021

Description

remove spatial_dims from the Warp and DVF2DDF constructor,
infer the spatial_dims automatically in forward.
these will simplify the usages.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Copy link
Copy Markdown
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@kate-sann5100
Copy link
Copy Markdown
Collaborator

Thanks!

@wyli wyli merged commit 83a6ad8 into Project-MONAI:master Mar 26, 2021
@wyli wyli deleted the infer-spatial-dims-warp branch April 28, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants