Skip to content

1852 Fix the prefetch issue in SmartCacheDataset#1855

Merged
wyli merged 4 commits intoProject-MONAI:masterfrom
Nic-Ma:1852-fix-smartcache
Mar 26, 2021
Merged

1852 Fix the prefetch issue in SmartCacheDataset#1855
wyli merged 4 commits intoProject-MONAI:masterfrom
Nic-Ma:1852-fix-smartcache

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Mar 26, 2021

Fixes #1852 .

Description

This PR changed to started check to the doc-string as PyTorch prefetch may access data before started.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 26, 2021

/black

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is a follow-up of #1832

@wyli wyli merged commit e0feb53 into Project-MONAI:master Mar 26, 2021
@Nic-Ma Nic-Ma deleted the 1852-fix-smartcache branch July 2, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SmartCache is not working in Clara Train

2 participants