Thanks for your quick update.
Looks good to me.
Could you please also add a test case to run your SmartCachePatchWSIDataset with SmartCacheHandler to make sure it can work well with our workflows?

Thanks.

Thanks @Nic-Ma ,
Using SmartCacheHandler requires to use a MONAI engine like SupervisedTraining, right? Is there any simpler way to test it?
I have already tested it with pathology MMAR and it worked.

Thanks for your quick update.
Looks good to me.
Could you please also add a test case to run your SmartCachePatchWSIDataset with SmartCacheHandler to make sure it can work well with our workflows?
Thanks.

Thanks @Nic-Ma ,
Using SmartCacheHandler requires to use a MONAI engine like SupervisedTraining, right? Is there any simpler way to test it?
I have already tested it with pathology MMAR and it worked.

Hi @behxyz ,

You can refer to this test program: https://github.com/Project-MONAI/MONAI/blob/master/tests/test_handler_smartcache.py

Thanks.

Thanks for your quick update.
Looks good to me.
Could you please also add a test case to run your SmartCachePatchWSIDataset with SmartCacheHandler to make sure it can work well with our workflows?
Thanks.

Thanks @Nic-Ma ,
Using SmartCacheHandler requires to use a MONAI engine like SupervisedTraining, right? Is there any simpler way to test it?
I have already tested it with pathology MMAR and it worked.

Hi @behxyz ,

You can refer to this test program: https://github.com/Project-MONAI/MONAI/blob/master/tests/test_handler_smartcache.py

Thanks.

@Nic-Ma, I need to finish all the other pathology components by the end of week and I've got a lot on my plate. I'll go back to it after that if you don't mind.

Thanks for your quick update.
Looks good to me.
Could you please also add a test case to run your SmartCachePatchWSIDataset with SmartCacheHandler to make sure it can work well with our workflows?
Thanks.

Thanks @Nic-Ma ,
Using SmartCacheHandler requires to use a MONAI engine like SupervisedTraining, right? Is there any simpler way to test it?
I have already tested it with pathology MMAR and it worked.

Hi @behxyz ,
You can refer to this test program: https://github.com/Project-MONAI/MONAI/blob/master/tests/test_handler_smartcache.py
Thanks.

@Nic-Ma, I need to finish all the other pathology components by the end of week and I've got a lot on my plate. I'll go back to it after that if you don't mind.

Sure, sounds good.
Thanks.

could you please address https://github.com/Project-MONAI/MONAI/pull/1853/files#r602317744 in this PR?

@wyli, I'll do it later in another PR since it affects almost all the pathology related unittests. It's on my to-do list.