Skip to content

Fully convolutional models based on TorchVision models#1845

Merged
bhashemian merged 11 commits intoProject-MONAI:masterfrom
bhashemian:behrooz_torch_model_fully_conv
Mar 25, 2021
Merged

Fully convolutional models based on TorchVision models#1845
bhashemian merged 11 commits intoProject-MONAI:masterfrom
bhashemian:behrooz_torch_model_fully_conv

Conversation

@bhashemian
Copy link
Copy Markdown
Member

Description

This PR build fully convolutional models based on any compatible torchvision model and convert the adaptive average pooling layer to a 7x7 average pooling. This model allows for using pre-trained torchvision models with any number of output classes, and most importantly enable a much faster inference in use cases like pathology where the input images are huge.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • [x ] Documentation updated, tested make html command in the docs/ folder.

@bhashemian bhashemian requested review from Nic-Ma and wyli March 25, 2021 00:38
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I put some comments inline

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! (the ValueError could be NotImplementedError, but feel free to keep the current one)

@bhashemian bhashemian enabled auto-merge (squash) March 25, 2021 17:45
@bhashemian bhashemian merged commit 8c13239 into Project-MONAI:master Mar 25, 2021
@bhashemian bhashemian deleted the behrooz_torch_model_fully_conv branch March 25, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants