1822 Implement Prob NMS#1842
Conversation
Signed-off-by: Yiheng Wang <[email protected]>
|
Hi @behxyz , could you please help to check the calculation first. I just tested locally, and will add formal test cases and doc string later. Compared with the startup code in #1800 , this version enhances:
|
Signed-off-by: Yiheng Wang <[email protected]>
bhashemian
left a comment
There was a problem hiding this comment.
Well done, @yiheng-wang-nv!
Apart from some minor changes, all looks good to me. So please add docstrings and unnittests, and move on from this to implement how to actually use it in conjunction with other components during inference.
|
@yiheng-wang-nv, maybe we should change the name from RadialNMS to PixelNMS or something. Because although we are receiving the radius as an input, we are suppressing over a square (or a cube) and not a circle (or a sphere). Unless, we use a radial base to suppress the pixels within the given radius. |
Agree, do you think we should also change the name of |
Signed-off-by: Yiheng Wang <[email protected]>
…o 1822-radial-nms
wyli
left a comment
There was a problem hiding this comment.
thanks I put some comments inline
|
@yiheng-wang-nv |
Signed-off-by: Yiheng Wang <[email protected]>
…o 1822-radial-nms
Signed-off-by: Yiheng Wang <[email protected]>
…o 1822-radial-nms
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang [email protected]
Fixes #1822 .
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.