Skip to content

1837 fixes collating data types#1839

Merged
wyli merged 4 commits intoProject-MONAI:masterfrom
wyli:1837-randaffined-collating
Mar 24, 2021
Merged

1837 fixes collating data types#1839
wyli merged 4 commits intoProject-MONAI:masterfrom
wyli:1837-randaffined-collating

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Mar 24, 2021

Signed-off-by: Wenqi Li [email protected]

Fixes #1837

Description

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.

@rijobro
Copy link
Copy Markdown
Contributor

rijobro commented Mar 24, 2021

The error was complaining about float/double mismatch, but the fix seems to focus on cuda/cpu. Could you explain? This will presumably cause conflict with #1836.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 1837-randaffined-collating branch from 195e824 to 2c686ae Compare March 24, 2021 09:53
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from Nic-Ma and rijobro March 24, 2021 13:25
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Mar 24, 2021

The error was complaining about float/double mismatch, but the fix seems to focus on cuda/cpu. Could you explain? This will presumably cause conflict with #1836.

thanks, now it's updated to address #1837 only

@rijobro
Copy link
Copy Markdown
Contributor

rijobro commented Mar 24, 2021

thanks @wyli !

@wyli wyli enabled auto-merge (squash) March 24, 2021 13:39
@wyli wyli merged commit cd08c00 into Project-MONAI:master Mar 24, 2021
@wyli wyli deleted the 1837-randaffined-collating branch April 28, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

randaffined collating datatype inconsistency

3 participants