1807 Enhance SmartCacheDataset with shuffle and exception#1832
Merged
Nic-Ma merged 8 commits intoProject-MONAI:masterfrom Mar 24, 2021
Merged
1807 Enhance SmartCacheDataset with shuffle and exception#1832Nic-Ma merged 8 commits intoProject-MONAI:masterfrom
Nic-Ma merged 8 commits intoProject-MONAI:masterfrom
Conversation
merge master
merge master
merge master
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
wyli
approved these changes
Mar 23, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks, I think the shuffling could be in a try...catch.... if data can't be shuffled, we still run the dataset with a warning message...
Contributor
Author
Thanks for your comments, updated in the latest commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1807 .
Description
This PR enhanced the
SmartCacheDatasetwith shuffling and exception messages.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.