Skip to content

1814 Enhance transform chain error logging#1829

Merged
Nic-Ma merged 10 commits intoProject-MONAI:masterfrom
Nic-Ma:1814-enhance-apply-trans
Mar 23, 2021
Merged

1814 Enhance transform chain error logging#1829
Nic-Ma merged 10 commits intoProject-MONAI:masterfrom
Nic-Ma:1814-enhance-apply-trans

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Mar 23, 2021

Fixes #1814 .

Description

This PR added DataStats to log more data information if an error happened in the transform chain.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 23, 2021

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli March 23, 2021 14:22
monai-bot and others added 2 commits March 23, 2021 14:24
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 23, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 23, 2021

/black

wyli
wyli approved these changes Mar 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! please merge if you could confirm that it works fine with the multiprocess loaders

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 23, 2021

thanks! please merge if you could confirm that it works fine with the multiprocess loaders

Hi @wyli ,

Thanks for your review.
I tested with our 3D segmentation integration test, it works fine with regular training and exception in transform case.

Thanks.

@Nic-Ma Nic-Ma enabled auto-merge (squash) March 23, 2021 22:12
@Nic-Ma Nic-Ma merged commit 07c6e34 into Project-MONAI:master Mar 23, 2021
@Nic-Ma Nic-Ma deleted the 1814-enhance-apply-trans branch July 2, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

apply_transform better error msg

3 participants

@Nic-Ma @wyli @monai-bot