Skip to content

1808 Drop post transforms from AUC metric#1828

Merged
Nic-Ma merged 8 commits intoProject-MONAI:masterfrom
Nic-Ma:1808-drop-args-auc
Mar 23, 2021
Merged

1808 Drop post transforms from AUC metric#1828
Nic-Ma merged 8 commits intoProject-MONAI:masterfrom
Nic-Ma:1808-drop-args-auc

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Mar 23, 2021

Fixes #1808 .

Description

This PR dropped the args of post transforms from AUC metric, it should be done by post transforms, same as other metrics.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 23, 2021

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 23, 2021

Hi @yiheng-wang-nv ,

Could you please help update the tutorials repo when this PR is merged? Just same as what you have done for other metrics before.

Thanks in advance.

monai-bot and others added 3 commits March 23, 2021 10:01
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 23, 2021

/black

@rijobro
Copy link
Copy Markdown
Contributor

rijobro commented Mar 23, 2021

Obviously it makes sense to sync AUC with the rest of the metrics, but should we not be worried about the break in backwards compatibility?

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 23, 2021

Obviously it makes sense to sync AUC with the rest of the metrics, but should we not be worried about the break in backwards compatibility?

Hi @rijobro ,

We changed other metrics to use post transforms in v0.4 release, seems no problems so far. So I think it's better to make it clear as soon as possible. @wyli @ericspod what do you think?

Thanks.

wyli
wyli approved these changes Mar 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Nic-Ma Nic-Ma merged commit 672ba95 into Project-MONAI:master Mar 23, 2021
@yiheng-wang-nv yiheng-wang-nv mentioned this pull request Mar 23, 2021
Closed
@Nic-Ma Nic-Ma deleted the 1808-drop-args-auc branch July 2, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@rijobro rijobro Awaiting requested review from rijobro

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need to drop activation and one-hot args in AUC

4 participants

@Nic-Ma @rijobro @wyli @monai-bot