Skip to content

Jupyter followup#1826

Merged
wyli merged 25 commits intoProject-MONAI:masterfrom
ericspod:jupyter_followup
Mar 23, 2021
Merged

Jupyter followup#1826
wyli merged 25 commits intoProject-MONAI:masterfrom
ericspod:jupyter_followup

Conversation

@ericspod
Copy link
Copy Markdown
Member

Description

Adds unit tests for MetricLogger and the plotting functions in jupyter_utils.py. These are tested by testing ThreadContainer.plot_status which will call all the plot functions currently present. The test involves saving a plot to a file and comparing against a stored file, this nails down what the plot is expected to create but doesn't test whether the plot is correct.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

ericspod and others added 25 commits March 16, 2021 13:15
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
@ericspod ericspod requested a review from wyli March 23, 2021 02:37
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit c4bb4cb into Project-MONAI:master Mar 23, 2021
@wyli wyli mentioned this pull request Mar 23, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants