[1823] allow None for switch endianness#1824
Merged
wyli merged 4 commits intoProject-MONAI:masterfrom Mar 22, 2021
Merged
Conversation
Signed-off-by: Richard Brown <[email protected]>
rijobro
changed the title
wyli
approved these changes
Mar 22, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks! could you help update the test cases https://github.com/Project-MONAI/MONAI/blob/master/tests/test_nifti_endianness.py#L48
Signed-off-by: Richard Brown <[email protected]>
Contributor
Author
|
Added test as per your issue. Failed prior to change to |
Contributor
|
/black |
Signed-off-by: monai-bot <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1823.
Description
Allow None as type for switching endianness. Also improve print statement for previously unseen data types.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.