Skip to content

remove .value from InverseKeys enum#1817

Merged
rijobro merged 1 commit intoProject-MONAI:masterfrom
rijobro:inversekeys_enum
Mar 22, 2021
Merged

remove .value from InverseKeys enum#1817
rijobro merged 1 commit intoProject-MONAI:masterfrom
rijobro:inversekeys_enum

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Mar 22, 2021

InverseKeys enum only ever gets used as string. So cleaner to not inherit from enum, therefore not needing .value throughout code.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@rijobro rijobro requested review from Nic-Ma, ericspod and wyli March 22, 2021 10:52
@rijobro rijobro enabled auto-merge (squash) March 22, 2021 10:52
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rijobro rijobro merged commit 5151b15 into Project-MONAI:master Mar 22, 2021
@rijobro rijobro deleted the inversekeys_enum branch March 22, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants